fix: Prevent scrollbar from overlapping side navigation content #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3002 +/- ##
=======================================
Coverage 96.30% 96.30%
=======================================
Files 771 777 +6
Lines 21820 21874 +54
Branches 7050 7069 +19
=======================================
+ Hits 21013 21066 +53
- Misses 799 800 +1
Partials 8 8 ☔ View full report in Codecov by Sentry. |
jperals
force-pushed
the
fix/navigation-scrollbar
branch
from
ae67374
to
6610e9a
Compare
jperals
force-pushed
the
fix/navigation-scrollbar
branch
2 times, most recently
from
64f12e0
to
2a0b53b
Compare
jperals
force-pushed
the
fix/navigation-scrollbar
branch
from
2a0b53b
to
d7a0409
Compare
jperals
force-pushed
the
fix/navigation-scrollbar
branch
from
d7a0409
to
25abc75
Compare
jperals
requested review from
connorlanigan and
jkuelz
and removed request for
a team
connorlanigan
approved these changes
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
timogasda
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: AWSUI-59956
Before (navigation content is too wide, and part of its padding is being overlapped by the scrollbar):
After (navigation content respects the available space excluding the scrollbar):
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.